Handle exec addr errors better - don't let IgnoreBadMemoryAccesses skip dispatcher exceptions #14085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, it'd be nice to keep it as an exec exception though? Or maybe not ever ignore bad jumps to invalid in -[Unknown] |
|
Yeah I'm not super happy with that either, this was just late night hacking to catch the error. I'll see what I can do. |
…ip dispatcher exceptions. It would then just fall through into the compiler and die. Should remove one of the "mystery" crashes from #14082.
hrydgard
force-pushed
the
catch-bad-exec-addr
branch
from
21fae17 to
f6b2070
Compare
| @@ -274,6 +274,11 @@ void Jit::Compile(u32 em_address) { | |||
| ClearCache(); | |||
| } | |||
|
|
|||
| if (!Memory::IsValidAddress(em_address)) { | |||
There was a problem hiding this comment.
Do we need this in ArmJit and Arm64Jit?
-[Unknown]
There was a problem hiding this comment.
I don't know if we need it at all. I think when using the JIT, the exception handler will always catch it in the dispatcher.
There was a problem hiding this comment.
Maybe there's some other path we end up in Compile, I dunno...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipping these would then just fall through into the compiler and die.
Should remove one of the "mystery" crashes from #14082.
x86 and ARM64 only for now, only tested on x86. will finish up tomorrow.
It handles this fine now (nice bluescreen):
hrydgard/pspautotests@1047400